Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] Implement retry queue and add retry limit #23

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

konstk1
Copy link
Contributor

@konstk1 konstk1 commented Aug 30, 2019

Fixes issue #22

Previously, if a server kept returning 401, results would be retried indefinitely.
@konstk1
Copy link
Contributor Author

konstk1 commented Aug 30, 2019

Note that I couldn't thoroughly test this because oauthbin.com doesn't seem to exist anymore. I run some other tests by mocking the interceptor to verify logic works.

@phimage
Copy link
Member

phimage commented Sep 5, 2019

thanks for the PR and the last commit
I do not know when PR
If you want I could merge now but you must do another PR when finally Alamofire will do a real release ...

@konstk1
Copy link
Contributor Author

konstk1 commented Sep 5, 2019

I think the last commit does not specify the dependency requirements correctly. Let me fix that first.

@phimage
Copy link
Member

phimage commented Sep 5, 2019

yes maybe for carthage too

@konstk1
Copy link
Contributor Author

konstk1 commented Sep 5, 2019

Ok, should be good to merge now. I'll issue another PR when Alamofire 5.0 is released.

Any idea what happened to oauthbin.com?

@phimage
Copy link
Member

phimage commented Sep 5, 2019

maybe down
I am looking for alternative
https://code-examples.net/en/q/35c905 maybe http://term.ie/oauth/example/index.php

@phimage phimage merged commit 84e7255 into OAuthSwift:master Sep 5, 2019
@phimage
Copy link
Member

phimage commented Sep 7, 2019

I make a new pr, updating carthage and travis file without a macOS so I do not really see the code running ut if this could help
https://travis-ci.org/OAuthSwift/OAuthSwiftAlamofire/jobs/581809211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants